revert sds name addition to gateway#781
Conversation
Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
googlebot
added
the
cla: yes
rshriram
requested review from
louiscryan and
wenchenglu
and removed request for
andraxylia and
hklai
costinm
left a comment
costinm
left a comment
There was a problem hiding this comment.
/lgtm
Let's try to use the gateway name in the implementation, so we can solve the immediate problem in ingress for 1.1 - we can add more APIs and customization in 1.2 after user feedback,
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: costinm, rshriram The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@rshriram We need to make an agreement for 1.1 so that we can make corresponding changes on Pilot early. Otherwise, we will have risk on delivering the feature in 1.1. |
|
@wenchenglu Please wait until Shriram agrees on the plan here: |
|
I would love to use the portName.gatwayName.namespace .. But how do you infer the name of the secret from this? You would have to read the gateway spec from k8s, and extract the specific gateway from the specific namespace, get to the specific server in the gateway using the portName. And from there, you look at the cert paths in the server (/etc/istio/certs//..), extract the secret and then fetch the secret. If this is okay by you, lets go for it. There is no need for any additional field. |
6 participants
While we continue to discuss the right way of introducing SDS config
into the gateway, revert the existing one which is not the right
way of introducing the feature as it goes against our current
API design, forcing users to specify all options (files, sds names, etc.)
without any idea of which one would be picked by the underlying system.
This might be useful for automation code but definitely not for end users
authoring configs.
Signed-off-by: Shriram Rajagopalan shriramr@vmware.com